Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove interweave autolinks #678

Merged
merged 5 commits into from
Mar 7, 2023
Merged

chore: remove interweave autolinks #678

merged 5 commits into from
Mar 7, 2023

Conversation

sasicodes
Copy link
Member

@sasicodes sasicodes commented Mar 7, 2023 •
edited

Description

Closes #513

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor changes in old functionality

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@sasicodes sasicodes linked an issue Mar 7, 2023 that may be closed by this pull request
Remove interweave-autolink dependency #513
Closed
@vercel
Copy link

vercel bot commented Mar 7, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
embed ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 2:32PM (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 2:32PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
api ⬜️ Ignored (Inspect) Mar 7, 2023 at 2:32PM (UTC)

@sasicodes sasicodes self-assigned this Mar 7, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 7, 2023
View reviewed changes
apps/web/src/components/Upload/ChooseThumbnail.tsx
@@ -160,7 +180,7 @@
>
<img
className="h-16 w-full rounded-lg object-cover md:w-32"
src={sanitizeDStorageUrl(thumbnail.url)}
src={sanitizeDStorageUrl(thumbnail.blobUrl)}

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML

[DOM text](1) is reinterpreted as HTML without escaping meta-characters.
@sasicodes sasicodes merged commit 911fdd3 into main Mar 7, 2023
@sasicodes sasicodes deleted the 513-remove-interweave-autolink-dependency branch March 7, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sasicodes sasicodes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove interweave-autolink dependency
1 participant
@sasicodes