Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: share modal item width #718

Merged
merged 5 commits into from
Mar 28, 2023
Merged

Conversation

chawyehsu
Copy link
Contributor

Description

Closes #717

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor changes in old functionality

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Signed-off-by: Chawye Hsu <chawyehsu@hotmail.com>
@vercel
Copy link

vercel bot commented Mar 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
api ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 6:35PM (UTC)
embed ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 6:35PM (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 6:35PM (UTC)

@vercel
Copy link

vercel bot commented Mar 28, 2023

@chawyehsu is attempting to deploy a commit to the Lenstube Team on Vercel.

A member of the Team first needs to authorize it.

@sasicodes
Copy link
Member

@chawyehsu can you share the issue this PR is fixing 🙇🏻 ?

@chawyehsu
Copy link
Contributor Author

@sasicodes thanks for reviewing, see #717 for the issue.

@sasicodes
Copy link
Member

sasicodes commented Mar 28, 2023

@sasicodes thanks for reviewing, see #717 for the issue.

got it, what happens when we try flex-none?

@chawyehsu
Copy link
Contributor Author

got it, what happens when we try flex-none?

Sorry I don't get it. where do you want to put flex-none? the parent div? If so, I don't think it helps in terms of the issue.

@sasicodes
Copy link
Member

got it, what happens when we try flex-none?

Sorry I don't get it. where do you want to put flex-none? the parent div? If so, I don't think it helps in terms of the issue.

I mean if we try flex-none instead of max-w-none, does it work?

@chawyehsu
Copy link
Contributor Author

I mean if we try flex-none instead of max-w-none, does it work?

nah, it doesn't help.

image

@sasicodes sasicodes merged commit 83371fc into tapexyz:main Mar 28, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Mar 28, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Lenstube Contributor:

GitPOAP: 2023 Lenstube Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@sasicodes
Copy link
Member

thanks for the PR @chawyehsu 💯

@vercel vercel bot temporarily deployed to Preview – api March 28, 2023 18:35 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] ShareModal looks teribble on mobile devices
2 participants