fix virtio download #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # RH now have a package | ||
| if [ -e "/usr/share/virtio-win/virtio-win.iso" ]; then | ||
| echo "Using ISO from virtio-win package." | ||
| ln -s /usr/share/virtio-win/virtio-win.iso ./virtio-win.iso; |
There was a problem hiding this comment.
This symlink seems messy, you could just set CDIMAGE to point straight at the ISO file, and combine this with the outer if statement.
|
Thanks! I can noodle around with the above later, at least this way master will work again :) |
|
thanks for looking into the pr. my reasoning for the link was to keep the |
|
Okay, good to know. Hopefully af97559 preserves this, and keeps working when your iso is called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.