Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support docks in Leo's core #1150

Closed
16 tasks done
edreamleo opened this issue May 19, 2019 · 5 comments
Closed
16 tasks done

Support docks in Leo's core #1150

edreamleo opened this issue May 19, 2019 · 5 comments
Assignees
Milestone

Comments

@edreamleo
Copy link
Member

edreamleo commented May 19, 2019

This issue is a revision of #777. It is independent of #1093: add pyzo features to Leo.

Started May 5, 2019. Code complete and debugged on May 30.

Status

  • The --dock command-line argument enables QDockWidgets.
  • Use QDockWidgets in Leo's top-level DynamicWindow class, a subclass of QMainWindow.
  • Put the outline and body panes in separate QDockWidgets.
  • The toggle-split-direction command just issues a warning when --dock is in effect.
  • Add convenience method, dw.createDockWidget.
  • Save/restore dock layout.
  • Put each additional body pane in a separate QDockWidget. This is worth doing.
  • Make the components of the Tabs dock dockable.
    legacy_log_dock switch in qt_frame.py:
    • True: the Spell & Find tabs remain in the Tabs dock.
    • False: Use separate docks for the Spell & Find tabs.
  • Add dock-related css to all Leo theme files. See below.

Bugs

  • Support docks in "Log pane" plugins #1154: Support g.app.dock in plugins.
  • Raise dockwidget with focus to top of tabified dock #1159: Raise dock widgets as needed.
  • Leo doesn't preserve the sizes of the main window properly. Fixed at 8119f8.
  • Problems saving/restoring dock positions with multiple outlines.
  • Tab completion doesn't ensure that the Tab dock is visible. Fixed at 18af67e.
  • Deferred: I'll fix these only if we decide to allow floatable docks.
  • Alt-x doesn't set focus properly when the body pane is free-floating.
  • After selecting a word in the body editor, Ctrl-f doesn't change the focus to the spell tab.
    The selection is transferred to the search field but the focus remains in the body tab.
  • Tab layout not correct in second outline. Fixed at 99cc3c9.
    Leo saves/restores per-outline dock state only, defaulting to a global state if necessary.

css

Here are the new entries in EKRWindowsDark.leo:

QMainWindow::separator {
    /* The separator between QDockWidget's. */
    background: @dark-base01;
    width: 4px; height: 4px;
    border: 2px solid black;
}
QDockWidget::title {
    color: @dark-base3;
    background: black;
    border: 1px solid @dark-base2;
}
QDockWidget::close-button, QDockWidget::float-button {
    background: @solarized-base01;
}
QLineEdit#editorLabel {
    border: 1px solid @dark-base2;
}

Qt Styles

Leo does not use Qt styles, and does not need to. pyzo issue #566 arose from confusion between Cleanlooks and Fusion styles. Alas, the cool Cleanlooks splitter "grip" is C++ code, so it can not easily be made part of Leo.

@edreamleo

This comment has been minimized.

@edreamleo edreamleo changed the title Base Leo on QDockWidget Support --dock to enable QDockWidgets May 22, 2019
@ghost
Copy link

ghost commented May 27, 2019

Selecting a word in the body editor and hitting Ctrl-f doesn't change the focus to the spell tab.

The selection is transferred to the search field but the focus remains in the body tab.

@edreamleo edreamleo changed the title Support --dock to enable QDockWidgets Support docks: QDockWidgets May 28, 2019
@edreamleo edreamleo changed the title Support docks: QDockWidgets Support docks in Leo's core May 31, 2019
@edreamleo
Copy link
Member Author

I am going to close this issue. Please reopen or file a separate issue if necessary.

@edreamleo
Copy link
Member Author

I am going to reopen this issue due to this post.

@edreamleo edreamleo reopened this Jun 1, 2019
@edreamleo
Copy link
Member Author

Lewis's recent bug has been fixed.

@edreamleo edreamleo removed the First label Jun 3, 2019
@edreamleo edreamleo added Maybe and removed Won'tDo Issues that EKR won't do labels Jun 22, 2019
@edreamleo edreamleo reopened this Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant