Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support global settings in .ini files #1298

Closed
edreamleo opened this issue Aug 23, 2019 · 3 comments
Closed

Support global settings in .ini files #1298

edreamleo opened this issue Aug 23, 2019 · 3 comments
Assignees
Labels
Enhancement Won'tDo Issues that EKR won't do

Comments

@edreamleo
Copy link
Member

edreamleo commented Aug 23, 2019

A text file, say leo_global_settings.ini, would contain just a few global settings. Leo would look for this file first in ~/.leo, and then in Leo's config directory.

Rationale

At present, Leo's theme files must load after myLeoSettings.leo, because myLeoSettings.leo specifies which theme to use. Instead, leo_global_settings.ini would specify the theme. Leo could then load the theme file before myLeoSettings.leo.

This feature has been requested before. There is now a real reason to allow this extra complication.

leo_global_settings.ini might replace some settings in g.app.db. This would make those settings more visible to the user, at the likely cost of complicating the affected code.

@edreamleo edreamleo added this to the 6.1 milestone Aug 23, 2019
@edreamleo edreamleo self-assigned this Aug 23, 2019
@maphew
Copy link
Member

maphew commented Aug 23, 2019

Maybe it should just be theme.ini. Yet another place to look for a what-the-heck-is-doing-this! setting sounds like a recipe to make what's already a confusing situation even more confusing. Though I do agree there needs to be some mechanism to float the settings people are most likely to want to change upwards.

@edreamleo
Copy link
Member Author

edreamleo commented Aug 23, 2019 via email

@edreamleo edreamleo removed this from the 6.1 milestone Aug 24, 2019
@edreamleo edreamleo added the Won'tDo Issues that EKR won't do label Aug 24, 2019
@edreamleo
Copy link
Member Author

edreamleo commented Aug 24, 2019

I'm going to close this issue and mark it "Won'tDo". As Matt says, this would just add to the settings confusion. I have just created #1301: Open theme files before myLeoSettings.leo. #1301 suggests that @string theme-name should be replaced by a setting in g.app.db or c.db.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Won'tDo Issues that EKR won't do
Projects
None yet
Development

No branches or pull requests

2 participants