Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leoscripts.leo contains all its scripts in an @file leoScripts.txt text file - is that OK? #3015

Closed
tbpassin opened this issue Dec 29, 2022 · 2 comments
Assignees
Labels

Comments

@tbpassin
Copy link
Contributor

tbpassin commented Dec 29, 2022

All of the scripts in leoscripts.leo are contained in a single text file: @file leoScripts.txt. That seems strange to me. Why is there such a file? The text file contains leo sentinels, since it is an @file node.

I imagine there was some apparently good reason behind this choice at some time in the past, but it's not apparent to me. Shouldn't the scripts just be in an ordinary organizer node? What is the value in having them saved outside the Leo outline in a .txt file that contains sentinels?

@tbpassin tbpassin added the Info label Dec 29, 2022
@tbpassin tbpassin added this to the 6.7.2 milestone Dec 29, 2022
@edreamleo
Copy link
Member

@tbpassin Hmm. It's a fair question. I don't recall why I thought the .txt file was a good idea. It may have had something to do with reducing git diffs...

@edreamleo edreamleo self-assigned this Jan 5, 2023
@edreamleo edreamleo removed this from the 6.7.2 milestone Jan 5, 2023
@edreamleo
Copy link
Member

@tbpassin We can leave scripts.leo as it is :-)

@edreamleo edreamleo added Help and removed Info labels Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants