Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up creation and use of KeyStroke class #394

Closed
edreamleo opened this issue Feb 1, 2017 · 1 comment
Closed

Clean up creation and use of KeyStroke class #394

edreamleo opened this issue Feb 1, 2017 · 1 comment
Assignees
Labels
Enhancement Won'tDo Issues that EKR won't do

Comments

@edreamleo
Copy link
Member

edreamleo commented Feb 1, 2017

This is an experimental project. It is made feasible because of git branches and Leo's cff command.

You would think that most of Leo's code could easily use strokes (instances of the KeyStroke class). But that's not true. There are two ways to attempt simplifications:

  1. Discover all places where strokes are created and used.
  2. Attempt to create new distinctions that are latent in the KeyStroke class.

As part of this simplification, it seems reasonable to move the code that creates KeyStroke objects from keyboard codes should move from the LeoQtEventFilter class into the LeoQtGui class.

@edreamleo edreamleo self-assigned this Feb 1, 2017
@edreamleo edreamleo added the EKR label Jan 22, 2018
@edreamleo
Copy link
Member Author

I am going to close this project. #423 supersedes it.

@edreamleo edreamleo added the Won'tDo Issues that EKR won't do label Jan 25, 2018
@edreamleo edreamleo removed the EKR label Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Won'tDo Issues that EKR won't do
Projects
None yet
Development

No branches or pull requests

1 participant