Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@persistence doesn't retain tags and links (uA's) #526

Closed
largo84 opened this issue Jul 13, 2017 · 12 comments
Closed

@persistence doesn't retain tags and links (uA's) #526

largo84 opened this issue Jul 13, 2017 · 12 comments
Assignees
Labels
Milestone

Comments

@largo84
Copy link
Contributor

largo84 commented Jul 13, 2017

  1. myLeoSettings.leo sets the following to override defaults:
    @bool enable-persistence = True
    @bool create-at-persistence-nodes-automatically = True
  2. Create @auto-md node.
    • Create several nodes.
    • Tag nodes using nodetags plugin.
    • Create links using backlink plugin.
  3. Save and close the xxx.leo file.
    • @persistence node is created if it was not there already.
  4. Re-open the xxx.leo file. All of the tags and links are missing.

The attached example files should illustrate behavior. Discussion of this on the forum here.
Environment:
Leo 5.5, build 20170712062357, Wed Jul 12 06:23:57 CDT 2017
Git repo info: branch = master, commit = bec5e26
Python 3.4.3, PyQt version 5.4.1
Windows 8 AMD64 (build 6.2.9200)
isPython3: True
caching enabled

@largo84 largo84 added the Bug label Jul 13, 2017
@largo84
Copy link
Contributor Author

largo84 commented Jul 13, 2017

Tried to attach a .leo and .md file, but got an error about file type not supported.

@tbnorth
Copy link
Contributor

tbnorth commented Jul 13, 2017

Links and I assume tags rely on v.u. Links also rely on persistence of gnxs, i.e. nodes in an auto file would need the same gnx to remain link targets. Just background for those that know how persistence works ;-)

@edreamleo
Copy link
Member

edreamleo commented Jul 13, 2017 via email

@edreamleo edreamleo self-assigned this Jul 13, 2017
@edreamleo edreamleo added this to the 5.6 milestone Jul 13, 2017
@edreamleo
Copy link
Member

edreamleo commented Jul 13, 2017

This looks like a fairly simple botch that has been around for months, if not years. I expect to fix this later today. It probably affects all kinds of @auto nodes.

@edreamleo
Copy link
Member

f302ae8 in the "persist" branch looks like it fixes this issue. However, more testing is needed. I'll leave this item open and will delay merging into master for a day at least.

@largo84
Copy link
Contributor Author

largo84 commented Jul 14, 2017

Not sure how to test this. I don't understand GitHub well enough (using GH Desktop for Windows) to know how to get this on my machine to try it. Also, I'll be traveling for the next several weeks, so testing will be intermittent at best.

@edreamleo
Copy link
Member

edreamleo commented Jul 14, 2017 via email

@largo84
Copy link
Contributor Author

largo84 commented Jul 14, 2017

First test of this branch looks good so far. All tags appear to be retained as expected.

@edreamleo
Copy link
Member

edreamleo commented Jul 14, 2017 via email

@largo84
Copy link
Contributor Author

largo84 commented Jul 14, 2017

Hmm, wondering if I'm the only one who uses it.

@edreamleo
Copy link
Member

edreamleo commented Jul 14, 2017 via email

@xgdomingo
Copy link

xgdomingo commented Jul 15, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants