Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LeoFS update-acl and get-acl method unexpected permission message display. #163

Closed
rr-paras-patel opened this issue Apr 1, 2014 · 3 comments
Assignees
Milestone

Comments

@rr-paras-patel
Copy link

Usually Amazon S3 having this kind of implementation for Canned ACL :

Canned ACL Applies to Applies to Permissions added to ACL
private Bucket and object Owner gets FULL_CONTROL. No one else has access rights (default).
public-read Bucket and object Owner gets FULL_CONTROL. The AllUsers group gets READ access.
public-read-write Bucket and object Owner gets FULL_CONTROL. The AllUsers group gets READ and WRITE access. Granting this on a bucket is generally not recommended.

But in LeoFS public-read and public-read-write owner doesn't show FULL_CONTROL. I checked this results via following steps :

Case 1 : update-acl test-bucket 05236 private

OK
get-buckets

bucket      | owner       | permissions  | created at                
------------+-------------+--------------+---------------------------
test-bucket | _test_leofs | full_control | 2014-04-01 14:38:46 +0900

get-bucket 05236

bucket      | permissions  | created at                
------------+--------------+---------------------------
test-bucket | full_control | 2014-04-01 14:38:46 +0900


Case 2 :update-acl test-bucket 05236 public-read

OK
get-buckets

bucket      | owner       | permissions  | created at                
------------+-------------+--------------+---------------------------
test-bucket | _test_leofs | read         | 2014-04-01 14:38:46 +0900

get-bucket 05236

bucket      | permissions  | created at                
------------+--------------+---------------------------
test-bucket | read         | 2014-04-01 14:38:46 +0900
% This permission should be display as  full_control


Case 3 :update-acl test-bucket 05236 public-read-write

OK
get-buckets

bucket      | owner       | permissions  | created at                
------------+-------------+--------------+---------------------------
test-bucket | _test_leofs | read,write   | 2014-04-01 14:38:46 +0900

get-bucket 05236

bucket      | permissions  | created at                
------------+--------------+---------------------------
test-bucket | read         | 2014-04-01 14:38:46 +0900
% This permission should be display as  full_control

In above code check Case No. 2,3 something is conflicting.

@yosukehara
Copy link
Member

I'll check it this issue. Thank you for your report.

@mocchira
Copy link
Member

mocchira commented Apr 2, 2014

Hi @Paras2009
I've fixed this issue as below.

Case 1 : update-acl test-bucket 05236 private

get-buckets
cluster id   | bucket   | owner       | permissions      | created at                
-------------+----------+-------------+------------------+---------------------------
leofs_1      | bbb      | _test_leofs | Me(full_control) | 2014-04-02 14:15:43 +0900

bucket   | permissions      | created at                
---------+------------------+---------------------------
bbb      | Me(full_control) | 2014-04-02 14:15:43 +0900

Case 2 :update-acl test-bucket 05236 public-read

get-buckets
cluster id   | bucket   | owner       | permissions                      | created at                
-------------+----------+-------------+----------------------------------+---------------------------
leofs_1      | bbb      | _test_leofs | Me(full_control), Everyone(read) | 2014-04-02 14:15:43 +0900

get-bucket 05236
bucket   | permissions                      | created at                
---------+----------------------------------+---------------------------
bbb      | Me(full_control), Everyone(read) | 2014-04-02 14:15:43 +0900

Case 3 :update-acl test-bucket 05236 public-read-write

get-buckets
cluster id   | bucket   | owner       | permissions                            | created at                
-------------+----------+-------------+----------------------------------------+---------------------------
leofs_1      | bbb      | _test_leofs | Me(full_control), Everyone(read,write) | 2014-04-02 14:15:43 +0900

get-bucket 05236
bucket   | permissions                            | created at                
---------+----------------------------------------+---------------------------
bbb      | Me(full_control), Everyone(read,write) | 2014-04-02 14:15:43 +0900

Could you check?

@rr-paras-patel
Copy link
Author

Yes I Confirmed this Updates. Results are as it expected. Thank you.

@yosukehara yosukehara added this to the 1.0.0 milestone Apr 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants