Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic SSE-C Implementation #1027

Closed
wants to merge 1 commit into from

Conversation

windkit
Copy link
Contributor

@windkit windkit commented Apr 12, 2018

Description

Currently only support small object PUT/GET without any checking
(internally leo_ssec does some checking, but errors are not handled in leo_gateway)

Related Issue

#114

Related PR

leo-project/leo_object_storage#28
leo-project/leo_commons#13

Copy link
Member

@mocchira mocchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to Encrypt/Decrypt data on leo_storage rather than leo_gateway as it's CPU intensive task and leo_gateway tend to saturate CPU OTOH leo_storage's CPU tend to be idle.

@yosukehara
Copy link
Member

yosukehara commented Apr 13, 2018

@windkit I and @mocchira, we discussed the way of its implementation. It should be implemented on LeoStorage as @mocchira mentioned. Once, I've close this PR, then we need to re-design it.

Thanks for your contribution.

@yosukehara yosukehara closed this Apr 13, 2018
@windkit
Copy link
Contributor Author

windkit commented Apr 13, 2018

yes, I have also thought about it, decrypt at leo_storage could be better for performance.

But decrypting at leo_storage means we have to send the key around, is the rpc traffic in Erlang encrypted?
Sending keys around is one issue, sending them in plain text is a big one.

@yosukehara
Copy link
Member

@windkit

But decrypting at leo_storage means we have to send the key around, is the rpc traffic in Erlang encrypted?
Sending keys around is one issue, sending them in plain text is a big one.

We need to consider its implementation way which includes your concern.

@yosukehara
Copy link
Member

Today, I’ve recognized #114’s design is not mature because there is no detailed design. We need to implement its function in a reliable way I believe, so I closed Wilson’s PR (I appreciate Wilson’s contribution). We need to write a design documentation especially new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants