remember disabled value of element before startLoading #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix leocaseiro#85. ngDisabled was called before startLoading and stopLoading is executed. But stopLoading always sets the disabled attribute to false, no mather to what value the disabled attribute was set by ngDisabled. That's why I save the disabled value to the directives scope before startLoading sets disabled=true and reset the disabled value to the saved on on stopLoading.
|
Hi @Odi55555 this is very promising and I'm happy to accept your PR. Could you just compile the chosen.js please? Thanks |
|
Hi, |
This was referenced Feb 27, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #85.
ngDisabled was called before startLoading and stopLoading is executed. But stopLoading always sets the disabled attribute to false, no mather to what value the disabled attribute was set by ngDisabled. That's why I save the disabled value to the directives scope before startLoading sets disabled=true and reset the disabled value to the saved on on stopLoading.