Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CharacterCasing property in MaterialTabSelector and SubtleEmphasis in FontType #281

Merged
merged 6 commits into from
Nov 8, 2021
Merged

Add CharacterCasing property in MaterialTabSelector and SubtleEmphasis in FontType #281

merged 6 commits into from
Nov 8, 2021

Conversation

valimaties
Copy link

@valimaties valimaties commented Nov 3, 2021

This property will allow users to set CharacterCasing from Text property for each Tab.

Demo:
CharacterCasing in TabSelector

As long it is my current using branch, I need all properties implemented, so it will include also LeaveOnEntryKey property, which I mention that does not affect current approach for textboxes, as long it is by default False.

Edit: This will add also SubtleEmphasis (MSWord Style) to MaterialSkinManager class. Will allow users to select italic FontType to MaterialLabel

SubtleEmphasis

@valimaties valimaties changed the title CharacterCasing property in MaterialTabSelector CharacterCasing property in MaterialTabSelector and SubtleEmphasis in FontType Nov 4, 2021
Copy link
Collaborator

@orapps44 orapps44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code you add in commit 'Restored EnabledChanged event' was removed to fix issue #282, why do you want to add it again ?

@valimaties
Copy link
Author

I have conflict in files.. And git shows me that code missing... I though I have to added it.. But, finally, I will remake this branch again, I don't know what is wrong, it shows me wrong code I think!

@valimaties
Copy link
Author

I've made all modification to this branch to have no conflicts. Now it is ok.

@orapps44 orapps44 merged commit 051d89b into leocb:master Nov 8, 2021
@orapps44 orapps44 changed the title CharacterCasing property in MaterialTabSelector and SubtleEmphasis in FontType Add CharacterCasing property in MaterialTabSelector and SubtleEmphasis in FontType Nov 8, 2021
@orapps44 orapps44 added this to the 2.3.0 milestone Nov 8, 2021
@valimaties valimaties deleted the TabSelectorCustomization_IncludingLeaveOnEnterKey branch November 8, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants