-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MaterialButton add Tab Focus #285
Conversation
Add focus to MaterialButton when Tab Key is pressed. Fix Enter KeyDown animation.
Hi @orapps44 , I've tested this PR, and it is not good approach! If you leave the button with mouse, you will lose the focused effect. You will not know which button has the focus. BTW: Look how Google implemented focused effect on their buttons: MouseOver and MouseLeave does not affect focused border... |
And BTW, it is not good to force Focus on a object only dragging mouse over it. That is not Focus, that is only hover! |
Right, I will rework that. |
Thanks :) |
Add _focusAnimationManager
That should work as expected with last commit. |
YEEESSS... This must be quickly merged 💯 |
Add focus to MaterialButton when Tab Key is pressed.
Fix Enter KeyDown animation.