Updates glium dependency to 0.30 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates to the latest version of glium (0.30), which brings glutin to version 0.27 and winit to 0.25. This fixes known issue [#1773](rust-windowing/winit#1773) in winit 0.19 on Linux X11. The key stubstanitive change to the examples is the change from glutin's `EventsLoop` to `EventLoop`. Instead of a user-defined while loop where `EventsLoop::poll_events` is called, `EventLoop` has switched to a run function which is event-driven by glutin's core. This slightly changes the program structure. The other changes are minor, as glutin moved a few data structures into modules instead of having everything visible at the top-level.
leod
approved these changes
Aug 15, 2021
There was a problem hiding this comment.
Wheee, thank you very much for contributing these changes! Updating the version of winit was long overdue.
Interestingly, without this PR, I just get Illegal instruction (core dumped) for every single example of rendology. I'm assuming that this could be related to #1773 in winit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates to the latest version of glium (0.30), which brings
glutin to version 0.27 and winit to 0.25. This fixes known issue
#1773 in winit
0.19 on Linux X11.
The key stubstanitive change to the examples is the change from glutin's
EventsLooptoEventLoop. Instead of a user-defined while loop whereEventsLoop::poll_eventsis called,EventLoophas switched to a runfunction which is event-driven by glutin's core. This slightly changes
the program structure.
The other changes are minor, as glutin moved a few data structures into
modules instead of having everything visible at the top-level.