Skip to content

Commit

Permalink
Merge 3b839b1 into 16fe010
Browse files Browse the repository at this point in the history
  • Loading branch information
leofavre committed Sep 8, 2018
2 parents 16fe010 + 3b839b1 commit eff5c55
Show file tree
Hide file tree
Showing 11 changed files with 316 additions and 1,391 deletions.
3 changes: 3 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
dist/
coverage/
node_modules/
62 changes: 3 additions & 59 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,61 +1,5 @@
# Logs
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# Bower dependency directory (https://bower.io/)
bower_components

# node-waf configuration
.lock-wscript

# Compiled binary addons (https://nodejs.org/api/addons.html)
build/Release

# Dependency directories
dist/
coverage/
node_modules/
jspm_packages/

# TypeScript v1 declaration files
typings/

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional REPL history
.node_repl_history

# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity

# dotenv environment variables file
.env

# next.js build output
.next
npm-debug.log*
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ language: node_js
node_js:
- '8'
script: npm test
after_script: npm run send-coverage
deploy:
provider: npm
email: leo@leofavre.com
Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## Unreleased

### Fixed

- Now the package has three distribution formats: ES6 modules, CommonJS and a global variable for browsers. This breaks the way importing behaves, making this release a major release.


## 1.0.1 - 2018-07-26

### Fixed
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

### Observed properties for native web components.

![](https://travis-ci.org/leofavre/observed-properties.svg?branch=master)
[![Build Status](https://travis-ci.org/leofavre/observed-properties.svg?branch=master)](https://travis-ci.org/leofavre/observed-properties) [![Coverage Status](https://coveralls.io/repos/github/leofavre/observed-properties/badge.svg?branch=feature%2Fbuild-system)](https://coveralls.io/github/leofavre/observed-properties?branch=feature%2Fbuild-system)

Have you ever wondered why native web components have an API to handle attribute changes but not property changes?

Expand All @@ -21,13 +21,13 @@ npm install observed-properties --save
Import `withObservedProperties`.

```javascript
import { withObservedProperties } from 'observed-properties';
import withObservedProperties from 'observed-properties';
```

Use the whole path to the `index.js` file if you want the script to [work on modern browsers natively](https://caniuse.com/#feat=es6-module), without having to depend on a build process.

```javascript
import { withObservedProperties } from './node_modules/observed-properties/index.js';
import withObservedProperties from './node_modules/observed-properties/src/index.js';
```

## Enhance HTMLElement
Expand Down
4 changes: 2 additions & 2 deletions karma.conf.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
process.env.CHROME_BIN = require('puppeteer').executablePath();

const filesPattern = '*.test.js';
const filesPattern = 'tests/index.test.js';

module.exports = (config) => {
config.set({
Expand Down Expand Up @@ -33,7 +33,7 @@ module.exports = (config) => {
esModules: true
}
},
exclude: /((node_modules)(\\|\/|$)|test.js$)/
exclude: /((node_modules)(\\|\/|$)|test\.js$)/
}
]
}
Expand Down

0 comments on commit eff5c55

Please sign in to comment.