Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft delete need the rest of the object to update #2

Closed
wants to merge 3 commits into from

Conversation

dandelionmood
Copy link

Hi !

Thanks for your work, it's proven quite useful to me !
I just noticed a little bug in the way the soft delete is written, here's my quick and dirty fix !

Pierre

@leomarquine
Copy link
Owner

But why are you passing all the items to the query? When soft deleting the only column you should update is the deleted_at column with the current time.

@dandelionmood
Copy link
Author

You're right, and that wasn't working either.
I updated the patch accordingly :) !

@leomarquine
Copy link
Owner

@dandelionmood any news on that?

@dandelionmood
Copy link
Author

hi @leomarquine the branch « branch-1 » should be OK !

@leomarquine
Copy link
Owner

So we really need this? If you don't set the column it will be bull anyway. Do you have any errors without it?

if( $this->delete === 'soft' ) {
    $item['deleted_at'] = null;
}

@leomarquine
Copy link
Owner

@dandelionmood ?

@dandelionmood
Copy link
Author

Sorry, I didn't have time to check it yet.

Pierre

@leomarquine leomarquine closed this Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants