Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akinator package #143

Closed
wants to merge 2 commits into from
Closed

Akinator package #143

wants to merge 2 commits into from

Conversation

facorazza
Copy link
Contributor

What type of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Documentation
  • Not Sure?

Does this PR introduce breaking changes?

  • Yes
  • No

List any relevant issue numbers:

Description:

Implements the Akinator game.

feat(package/akinator): Initital commit
@louistiti
Copy link
Member

Hello @Imperator26,

It looks awesome! Regarding the answer in the same context, this is where this feature request will be useful.
Because for the moment, it only works according to hard coded answer from the user such as "yes", "no", etc. And in English only.

@facorazza
Copy link
Contributor Author

Hello @Imperator26,

It looks awesome! Regarding the answer in the same context, this is where this feature request will be useful.
Because for the moment, it only works according to hard coded answer from the user such as "yes", "no", etc. And in English only.

Yep that would be perfect

@ThomasRitaine
Copy link

Hello !

You should consider renaming your akinator package into a games package, and keeping your module inside.
It would be better for those who want to add other games.

Thanks for contributing !

@theoludwig theoludwig added the feature request Indicates new feature requests. label Apr 24, 2021
@louistiti
Copy link
Member

Due to the complete new rewrite with the new skills architecture. This PR does not work and an Akinator skill has been built with the new architecture already 😃

@louistiti louistiti closed this Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Indicates new feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants