Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Italian translation and fixes some spelling errors #94

Closed
wants to merge 10 commits into from
Closed

Adds Italian translation and fixes some spelling errors #94

wants to merge 10 commits into from

Conversation

facorazza
Copy link
Contributor

What type of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Documentation
  • Not Sure?

Does this PR introduce breaking changes?

  • Yes
  • No

List any relevant issue numbers:

Description:

@louistiti
Copy link
Member

✨ Languages support

@louistiti
Copy link
Member

Hello @Imperator26,

Awesome work! Thanks for that!

I'll keep this PR pending until we focus on more languages integrations. Because we need to spend some time to implement the Italian voice according to the different providers.

@facorazza facorazza changed the title Adds Italian translation and fizes some spelling errrors Adds Italian translation and fixes some spelling errors May 14, 2019
@louistiti
Copy link
Member

Hello @Imperator26,

Could you please open another PR for your Weather package and keep that one dedicated to the Italian translation? 😃

@facorazza
Copy link
Contributor Author

Hello @Imperator26,

Could you please open another PR for your Weather package and keep that one dedicated to the Italian translation? 😃

Sure, but these fixes were about other packages.

@louistiti
Copy link
Member

louistiti commented Jun 9, 2019

What I mean is your work on your Weather package is getting into this PR too (e.g. https://github.com/leon-ai/leon/pull/94/files#diff-760b575aacb8cc2efd07b87b9ebd2596).

That must completely be part of another PR.

@facorazza
Copy link
Contributor Author

What I mean is your work on your Weather package is getting into this PR too (e.g. https://github.com/leon-ai/leon/pull/94/files#diff-760b575aacb8cc2efd07b87b9ebd2596).

That must completely be part of another PR.

Yeah sorry I realized I messed this PR up.

@facorazza
Copy link
Contributor Author

@louistiti quick question should I commit changes to package-lock.json?

@louistiti
Copy link
Member

Yes you can but it is not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants