This repository has been archived by the owner on Jan 27, 2019. It is now read-only.
MongoOptions Support fixes #36 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 22, 2013 15:42
Conflicts: src/test/scala/se/radley/plugin/salat/SalatSpec.scala
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented, in a separate Object, the loading of custom mongo options from a config node under mongo source in application.config. I really needed to increase the number of connections per host as I'm using the plugging in a web app with a high throughput and it was throwing a lot of "Out of semaphores to get db connection" exceptions all the time.
In the plugin I create a MongoConnection with MongoOptions only if some is present in the configuration.
I've also created the proper tests for all the code I've added.
Thank you for creating such a nice and useful plugin!
Gaston M. Tonietti
@ktonga