Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sweep Rules] Fix missing branch name and description in RESULTS.md #29

Closed
wants to merge 5 commits into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Feb 18, 2024

PR Feedback: 馃憥

I created this PR to address this rule:

"When merging pull requests, make sure to include the branch name and a brief description of the changes."

Description

This PR addresses the issue of missing branch name and description in the RESULTS.md file. The branch name and description are important for providing context and making it easier for others to understand the changes made in the pull request.

The following changes have been made to fix the issue:

  • Added command-line arguments to the benchmark.py script to specify the branch name and description.
  • Updated the benchmark.py script to include the branch name and description in the benchmark results.
  • Modified the run_on_changes.py script to pass the branch name and description as command-line arguments when executing benchmark commands.

Summary of Changes

  • Modified benchmark.py to include command-line arguments for branch name and description.
  • Updated the runScript function in benchmark.py to accept branch name and description as parameters.
  • Updated the loadConfiguration function in benchmark.py to include branch name and description in the configuration dictionary.
  • Added a new line at the beginning of RESULTS.md to include the branch name and description.
  • Modified run_on_changes.py to pass branch name and description as command-line arguments when executing benchmark commands.

Please review and merge this PR to fix the issue. Thank you!

Copy link
Contributor Author

sweep-ai bot commented Feb 18, 2024

Rollback Files For Sweep

  • Rollback changes to benchmark.py
  • Rollback changes to benchmark.py
  • Rollback changes to benchmark.py
  • Rollback changes to benchmark.py
  • Rollback changes to benchmark.py
  • Rollback changes to benchmark.py
  • Rollback changes to benchmark.py
  • Rollback changes to benchmark.py
  • Rollback changes to run_on_changes.py
  • Rollback changes to run_on_changes.py

@sweep-ai sweep-ai bot added the sweep label Feb 18, 2024
@leon0399 leon0399 closed this Feb 18, 2024
@leon0399 leon0399 deleted the sweep/fix-missing-branch-description branch June 29, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant