fix(process): fail if any of the steps fails #42
Conversation
* fix --post-success option description * add a new --mock-push option for testing purposes * add a test for successful post-success invocation BREAKING CHANGE: If pre-commit, git push or post-commit fails the whole program will also now fail with non-0 exit code. ISSUES CLOSED: leonardoanalista#40
2 similar comments
| commitFeat(); | ||
| const out = semanticRelease(`--post-success do-publish -v`); | ||
| const result = semanticRelease(`--post-success "npm run do-publish" -v`); |
There was a problem hiding this comment.
I can't quite follow how this test is passing now. From what I understand, L385 will detect that a release is required and call git push. Does git push within this system test return 0 now (instead of 128)? Can you explain further, please?
There was a problem hiding this comment.
Hi, sure. I've added an option to the whole command that tells it to mock the git push step and return specific code. Then I've added it to semanticRelease, so that it succeeds. Then if a test wants it to fail it can call semanticRelease with --mock-push 1, as options added later override those added earlier.
This is of course a very hacky solution, but I don't see any other possibility without more refactoring (see #41), which would be out of scope of this change.
| @@ -373,8 +421,7 @@ describe('corp-semantic-release', function() { | |||
| // } | |||
|
|
|||
| function semanticRelease(params) { | |||
| let result = shell.exec(`node ${__dirname}/../src/index.js ${params || ''}`); | |||
| return result.stdout; | |||
| return shell.exec(`node ${__dirname}/../src/index.js --mock-push 0 ${params || ''}`); | |||
There was a problem hiding this comment.
Ah, that's what I missed. Thank you.
| @@ -21,8 +21,13 @@ module.exports = function addFilesAndCreateTag(newVersion) { | |||
|
|
|||
| // ###### PUSH CHANGES ##### | |||
| log.info('>>...and push to remote...'); | |||
| code = shell.exec('git push && git push --tags').code; | |||
| if (mockPush === undefined) { | |||
|
Looks good to me 👍🏻 |
|
@leonardoanalista Good to merge? |
There was a problem hiding this comment.
Hi @mlazowik thanks for the PR. New file runScript.js is the one to wrap the scripts execution and terminate or not the process on fail. Thank you. 👍
BREAKING CHANGE:
If pre-commit, git push or post-commit fails the whole program will also now fail with non-0 exit
code.
ISSUES CLOSED: #40