Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue66 with ci-skip parameter #71

Merged
merged 5 commits into from
Mar 19, 2019
Merged

Issue66 with ci-skip parameter #71

merged 5 commits into from
Mar 19, 2019

Conversation

FranzNieschalk
Copy link
Contributor

Continuing the work of @Biboba, I checked out his issue66 branch, addressing your feedback from #67:

  • updated README
  • renamed parameter to ci-skip
  • set default of parameter to false

Hope it closes #66, we need this feature desperately.

Nicolas Guilhaudin and others added 5 commits February 25, 2019 18:38
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 93.676% when pulling 733f89d on ai4bd:issue66 into 5ba2d66 on leonardoanalista:master.

Copy link
Owner

@leonardoanalista leonardoanalista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FranzNieschalk thanks for the PR. It looks good to me.

@leonardoanalista leonardoanalista merged commit 8293280 into leonardoanalista:master Mar 19, 2019
@leonardoanalista
Copy link
Owner

Thanks again for the PR! I merged and changed the a braking change if you don't mind. The default true could affect existing users upgrading to this version.

@FranzNieschalk
Copy link
Contributor Author

@leonardoanalista Thank you for accepting and merging this PR. Could you release these changes on npm?

@leonardoanalista
Copy link
Owner

Think this didn’t get released again. I’ll need to look at this issue in the next few days

@FranzNieschalk
Copy link
Contributor Author

@leonardoanalista Bumping for new release (sorry for that).

leonardoanalista added a commit that referenced this pull request May 16, 2019
It seems like the latest commit release didn't work. See #71 (comment)
leonardoanalista added a commit that referenced this pull request May 16, 2019
It seems like the latest commit release didn't work. See #71 (comment)
@leonardoanalista
Copy link
Owner

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI option
3 participants