fix: repository path not being inferred

src/dotnet-affected.Tests/RepositoryPathTests.cs

@@ -0,0 +1,56 @@
+using Affected.Cli.Commands;
+using System;
+using System.Collections;
+using System.Collections.Generic;
+using System.Linq;
+using Xunit;
+
+namespace Affected.Cli.Tests
+{
+    public class RepositoryPathTests
+    {
+        private class TestPathsClassData : IEnumerable<object[]>
+        {
+            public IEnumerator<object[]> GetEnumerator()
+            {
+                yield return new object[]
+                {
+                    "/home/lchaia/dotnet-affected", "", "/home/lchaia/dotnet-affected"
+                };
+                yield return new object[]
+                {
+                    "", "/home/lchaia/dotnet-affected/Affected.sln", "/home/lchaia/dotnet-affected"
+                };
+                yield return new object[]
+                {
+                    "/home/lchaia/dotnet-affected", "/home/lchaia/dotnet-affected/subdirectory/other/Affected.sln",
+                    "/home/lchaia/dotnet-affected"
+                };
+                yield return new object[]
+                {
+                    "", "", Environment.CurrentDirectory
+                };
+            }
+
+            IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
+        }
+
+        [Theory]
+        [ClassData(typeof(TestPathsClassData))]
+        public void Should_determine_repository_path_correctly(
+            string repositoryPath,
+            string solutionPath,
+            string expected)
+        {
+            var data = new CommandExecutionData(
+                repositoryPath,
+                solutionPath,
+                string.Empty,
+                string.Empty,
+                false,
+                Enumerable.Empty<string>());
+
+            Assert.Equal(expected, data.RepositoryPath);
+        }
+    }
+}

src/dotnet-affected/Commands/AffectedRootCommand.cs

@@ -81,7 +81,8 @@ public RepositoryPathOptions()
                         "--repository-path", "-p"
                     })
             {
-                this.Description = "Path to the root of the repository, where the .git directory is.";
+                this.Description = "Path to the root of the repository, where the .git directory is.\n" +
+                                   "[Defaults to current directory, or solution's directory when using --solution-path]";
             }
         }
 
@@ -94,7 +95,8 @@ public SolutionPathOption()
                 })
             {
                 this.Description =
-                    "Path to a Solution file (.sln) used to find all projects that may be affected. When omitted, will search for project files inside --repository-path.";
+                    "Path to a Solution file (.sln) used to discover projects that may be affected. " +
+                    "When omitted, will search for project files inside --repository-path.";
             }
         }
 

src/dotnet-affected/Commands/Context/CommandExecutionContext.cs

@@ -3,7 +3,6 @@
 using System.Collections.Generic;
 using System.CommandLine;
 using System.CommandLine.IO;
-using System.IO;
 using System.Linq;
 
 namespace Affected.Cli.Commands
@@ -16,7 +15,6 @@ internal class CommandExecutionContext : ICommandExecutionContext
         private readonly Lazy<IEnumerable<ProjectGraphNode>> _changedProjects;
         private readonly Lazy<IEnumerable<ProjectGraphNode>> _affectedProjects;
         private readonly Lazy<ProjectGraph> _graph;
-        private readonly Lazy<string> _repositoryPath;
 
         public CommandExecutionContext(
             CommandExecutionData executionData,
@@ -31,7 +29,6 @@ internal class CommandExecutionContext : ICommandExecutionContext
             // For error handling to be managed properly at the handler level,
             // we use Lazies so that its done on demand when its actually needed
             // instead of happening here on the constructor
-            _repositoryPath = new Lazy<string>(DetermineRepositoryPath);
             _graph = new Lazy<ProjectGraph>(BuildProjectGraph);
             _changedProjects = new Lazy<IEnumerable<ProjectGraphNode>>(DetermineChangedProjects);
             _affectedProjects = new Lazy<IEnumerable<ProjectGraphNode>>(
@@ -63,31 +60,6 @@ private ProjectGraph BuildProjectGraph()
             return output;
         }
 
-        private string DetermineRepositoryPath()
-        {
-            // the argument takes precedence.
-            if (!string.IsNullOrWhiteSpace(_executionData.RepositoryPath))
-            {
-                return _executionData.RepositoryPath;
-            }
-
-            // if no arguments, then use current directory
-            if (string.IsNullOrWhiteSpace(_executionData.SolutionPath))
-            {
-                return Environment.CurrentDirectory;
-            }
-
-            // When using solution, and no path specified, assume the solution's directory
-            var solutionDirectory = Path.GetDirectoryName(_executionData.SolutionPath);
-            if (string.IsNullOrWhiteSpace(solutionDirectory))
-            {
-                throw new InvalidOperationException(
-                    $"Failed to determine directory from solution path {_executionData.SolutionPath}");
-            }
-
-            return solutionDirectory;
-        }
-
         private IEnumerable<ProjectGraphNode> DetermineChangedProjects()
         {
             if (!_executionData.AssumeChanges.Any())
@@ -105,7 +77,7 @@ private IProjectDiscoverer BuildProjectDiscoverer()
         {
             if (string.IsNullOrWhiteSpace(_executionData.SolutionPath))
             {
-                WriteLine($"Discovering projects from {_repositoryPath.Value}");
+                WriteLine($"Discovering projects from {_executionData.RepositoryPath}");
                 return new DirectoryProjectDiscoverer();
             }
 
@@ -118,9 +90,9 @@ private IEnumerable<ProjectGraphNode> FindNodesThatChangedUsingChangesProvider()
             // Get all files that have changed
             var filesWithChanges = this._changesProvider
                 .GetChangedFiles(
-                    _repositoryPath.Value,
-                    this._executionData.From,
-                    this._executionData.To)
+                    _executionData.RepositoryPath,
+                    _executionData.From,
+                    _executionData.To)
                 .ToList();
 
             // Match which files belong to which of our known projects

src/dotnet-affected/Commands/Context/CommandExecutionData.cs

@@ -1,4 +1,6 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
+using System.IO;
 using System.Linq;
 
 namespace Affected.Cli.Commands
@@ -11,14 +13,14 @@ namespace Affected.Cli.Commands
     internal class CommandExecutionData
     {
         public CommandExecutionData(
-           string repositoryPath,
-           string solutionPath,
-           string from,
-           string to,
-           bool verbose,
-           IEnumerable<string>? assumeChanges)
+            string repositoryPath,
+            string solutionPath,
+            string from,
+            string to,
+            bool verbose,
+            IEnumerable<string>? assumeChanges)
         {
-            this.RepositoryPath = repositoryPath;
+            this.RepositoryPath = DetermineRepositoryPath(repositoryPath, solutionPath);
             this.SolutionPath = solutionPath;
             this.To = to;
             this.From = from;
@@ -29,13 +31,38 @@ internal class CommandExecutionData
         public string RepositoryPath { get; }
 
         public string SolutionPath { get; }
-        
+
         public string From { get; }
 
         public string To { get; }
 
         public bool Verbose { get; }
 
         public IEnumerable<string> AssumeChanges { get; }
+
+        private static string DetermineRepositoryPath(string repositoryPath, string solutionPath)
+        {
+            // the argument takes precedence.
+            if (!string.IsNullOrWhiteSpace(repositoryPath))
+            {
+                return repositoryPath;
+            }
+
+            // if no arguments, then use current directory
+            if (string.IsNullOrWhiteSpace(solutionPath))
+            {
+                return Environment.CurrentDirectory;
+            }
+
+            // When using solution, and no path specified, assume the solution's directory
+            var solutionDirectory = Path.GetDirectoryName(solutionPath);
+            if (string.IsNullOrWhiteSpace(solutionDirectory))
+            {
+                throw new InvalidOperationException(
+                    $"Failed to determine directory from solution path {solutionPath}");
+            }
+
+            return solutionDirectory;
+        }
     }
 }