Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increases page size when fetching commits #157

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

leonardowf
Copy link
Owner

When fetching commits, from an interval, not specifying page size will result in only 30 results 😮‍💨

Ideally we keep fetching if there are more results in the page, but for now I will increase the page to the limit Github allows

Copy link

github-actions bot commented Dec 8, 2023

Total Coverage: 89.21

Coverage report

> baroneza@1.0.0 coverage
> jest --coverage

-------------------------------------|---------|----------|---------|---------|-------------------------

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 88.84 63.95 80.42 89.21
endpoints 70.91 12.5 62.96 70.91
create-release-endpoint.ts 85.71 0 66.67 85.71 50
guess-next-release-endpoint.ts 0 0 0 0 1-40
release-version-endpoint.ts 100 75 100 100 50
start-train-endpoint.ts 87.5 0 75 87.5 37
tag-endpoint.ts 92.31 0 80 92.31 72
update-release-endpoint.ts 0 0 0 0 1-35
use-cases 95 76.19 92.74 94.98
ask-confirmation-use-case.ts 100 100 100 100
create-branch-use-case.ts 63.64 100 25 63.64 31-42
create-changelog-use-case.ts 96.08 80 100 96.08 225,245
create-milestone-use-case.ts 94.74 50 100 94.74 57
create-release-use-case.ts 97.37 66.67 87.5 97.37 143
create-version-use-case.ts 100 100 100 100
extract-tickets-use-case.ts 100 100 100 100
merge-back-use-case.ts 100 100 100 100
read-pull-request-info-use-case.ts 100 100 100 100
release-version-use-case.ts 100 100 100 100
start-train-use-case.ts 100 100 100 100
tag-use-case.ts 96.15 100 90.91 96.15 116
update-release-use-case.ts 85.42 50 84.62 85.42 163-171,185,205,261,288
workers 77.4 84.78 56.92 79.41
branch-creator.ts 100 100 100 100
commit-extractor.ts 58.33 100 33.33 58.33 40-59
github-draft-release-guesser.ts 90.91 50 100 90.48 35,54
jira-tagger.ts 27.27 100 7.69 35.29 28-65
jira-ticket-parser.ts 100 91.67 100 100 18
keep-changelog-parser.ts 100 100 100 100
message-sender.ts 50 0 20 50 30-60
milestone-creator.ts 100 100 100 100
pr-number-extractor.ts 100 100 100 100
pull-request-creator.ts 60 100 25 60 29-47
pull-request-description-writer.ts 0 100 0 0 8-22
reactions-reader.ts 72.73 50 40 72.73 36-47
release-page-creator.ts 100 100 100 100
sha-finder.ts 100 100 100 100
workers/keep-changelog-builder 99.02 57.14 100 98.84
commits-pr-number-parser.ts 100 100 100 100
keep-changelog-builder.ts 100 0 100 100 27
markdown-keep-changelog-builder.ts 100 62.5 100 100 32-62
slack-keep-changelog-builder.ts 97.83 50 100 97.22 36
------------------------------------- --------- ---------- --------- --------- -------------------------

@leonardowf leonardowf merged commit 0ead10a into master Dec 8, 2023
5 checks passed
@leonardowf leonardowf deleted the lwf/increases-page-size branch December 8, 2023 14:36
Copy link

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to investigate the issue 🙏

For reference, this was observed REDACTED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants