Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: code cleanup #129

Merged
merged 4 commits into from
Oct 30, 2022
Merged

chore: code cleanup #129

merged 4 commits into from
Oct 30, 2022

Conversation

xhayper
Copy link
Collaborator

@xhayper xhayper commented Oct 27, 2022

Why?

Make it easier to add support for future feature, and make it easier for contributor to contribute their code.

Example for above case

make it easier to add support for #121

@xhayper xhayper marked this pull request as draft October 27, 2022 07:08
@xhayper xhayper self-assigned this Oct 27, 2022
@xhayper xhayper added the enhancement New feature or request label Oct 27, 2022
@xhayper xhayper removed their assignment Oct 27, 2022
@xhayper
Copy link
Collaborator Author

xhayper commented Oct 29, 2022

fixes #131

@xhayper xhayper linked an issue Oct 29, 2022 that may be closed by this pull request
@xhayper xhayper marked this pull request as ready for review October 29, 2022 04:16
@xhayper xhayper merged commit 3a1c34b into main Oct 30, 2022
@xhayper xhayper deleted the chore/code-cleanup branch October 30, 2022 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Button] Github link doesn't work after idle state
1 participant