fix(#145, #111): force set instance to true when sending activity #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sending activity
|
If this doesnt work I am crying |
|
Also set untilted to an allowed schema now that we fixed the ssh leaking. (this is the state that vscode responds with when in a new file) |
|
Till this day, i have no idea what instance field does, what does it do? |
|
Tbh I have no idea what it actually does. When bugging out the client to reproduce it. It showed up in debug. Setting it to true makes it reconnect so it works lol My best guess is saying it is attached to a discord instance |
|
I see, i am just curious, so nw about not knowing it LOL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that when it failed rpc set the instance to false. Force setting instance to true when activity is sent means that it should never be in a state where it wont work. After reconnecting from a connection timeout error or other from Discord rpc the plugin should still be able to reconnect and work
Closes #145 & #111