Fix activity state logic (#197) #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This breaks ignored git repos as it is removing the inactive state which is what ignored git repos should be as I stated in #197 (comment). I also can not recreate the problems that you are facing at all and every state that I can think of works. There is a logic flaw if this is occurring but I think we should fix whatever is happening rather then do this. Inactive state has only ever been used when isGitExluded https://gyazo.com/fcde08849f500438cd7e1ae8f97a6fd5 this is the logic it was before my commit |
nick22985
added a commit
to nick22985/vscord
that referenced
this pull request
Mar 28, 2023
xhayper
added a commit
that referenced
this pull request
Mar 28, 2023
revert: #198 breaks ignored orgs/repo buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the main issue raised in #197.
The logic for selecting current state was slightly off, and it would lead to the first button having very weird behavior (more details in the issue).