Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: git integration #35

Merged
merged 2 commits into from
Dec 30, 2021
Merged

feat: git integration #35

merged 2 commits into from
Dec 30, 2021

Conversation

TimTechDev
Copy link
Contributor

  • Add git.d.ts from microsoft/vscode
  • Add gitManager.ts where we extract the required strings
  • Dispose of gitManager.ts in extension.ts
  • Add {{git_repo}} and {{git_branch}} placehoders to constants.ts and activity.ts
  • Remove hacky getGitRepo function from utils.ts
  • Update package.json config descriptions
  • Update READEME.md and fix some typos

fix #25

- Add git.d.ts from microsoft/vscode
- Add gitManager.ts where we extract the required strings
- Dispose of gitManager.ts in extension.ts
- Add {{git_repo}} and {{git_branch}} placehoders to constants.ts and activity.ts
- Remove hacky getGitRepo function from utils.ts
- Update package.json config descriptions
- Update READEME.md and fix some typos

fix #25

Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
@leonardssh leonardssh added the enhancement New feature or request label Nov 8, 2021
@TimTechDev
Copy link
Contributor Author

Currently, very unstable git repo detection. Will need some work.

@leonardssh
Copy link
Owner

👍

Version two of the git integration. Added internal file listener.

    Tim

Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
README.md Show resolved Hide resolved
@TimTechDev
Copy link
Contributor Author

I would say you can check this PR now. The git feature is working reliable now. But I would like to make a second version if I have the time to do so. Because we could add/remove listeners and update the RPC only if the configuration needs it.

onConfigurationChange=>

choose from:
listeners for files
listeners for git
listeners for workspaces

To reduce the amount of updates caused by file changes or git if there is only a need for the current workspace or just a custom string.

@TimTechDev TimTechDev marked this pull request as ready for review November 14, 2021 13:03
@TimTechDev
Copy link
Contributor Author

Just found a bug in the code. It remains permanently at idle.

@TimTechDev TimTechDev marked this pull request as draft November 14, 2021 15:50
@leonardssh leonardssh mentioned this pull request Nov 16, 2021
4 tasks
@TimTechDev
Copy link
Contributor Author

Thanks for the ping! I may have forgotten this PR… In any case, I tried to reproduce the bug I mentioned, but I can't reproduce it. I can confirm, however: The feature works. You may merge it now. If any issue crops up, I'll be in touch.

@TimTechDev TimTechDev marked this pull request as ready for review December 30, 2021 14:15
@leonardssh
Copy link
Owner

I'm glad to hear that, I'll give this PR a pull to test if everything is ok before merge it.

@leonardssh leonardssh merged commit 64ed891 into leonardssh:main Dec 30, 2021
@leonardssh leonardssh mentioned this pull request Aug 7, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git branch string
2 participants