-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: git integration #35
Conversation
- Add git.d.ts from microsoft/vscode - Add gitManager.ts where we extract the required strings - Dispose of gitManager.ts in extension.ts - Add {{git_repo}} and {{git_branch}} placehoders to constants.ts and activity.ts - Remove hacky getGitRepo function from utils.ts - Update package.json config descriptions - Update READEME.md and fix some typos fix #25 Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
Currently, very unstable git repo detection. Will need some work. |
👍 |
Version two of the git integration. Added internal file listener. Tim Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
I would say you can check this PR now. The git feature is working reliable now. But I would like to make a second version if I have the time to do so. Because we could add/remove listeners and update the RPC only if the configuration needs it.
To reduce the amount of updates caused by file changes or git if there is only a need for the current workspace or just a custom string. |
Just found a bug in the code. It remains permanently at idle. |
Thanks for the ping! I may have forgotten this PR… In any case, I tried to reproduce the bug I mentioned, but I can't reproduce it. I can confirm, however: The feature works. You may merge it now. If any issue crops up, I'll be in touch. |
I'm glad to hear that, I'll give this PR a pull to test if everything is ok before merge it. |
fix #25