-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging module #10
Conversation
Similar to magma logging module (magma/magma/logging.py).
Rebased this branch on master with the pep8 changes merged. |
fault/logging.py
Outdated
if sys.version_info < (3, 5): | ||
return frame[0] | ||
else: | ||
return frame.frame |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this extra logic for wire tracebacks. Can we remove this function and simplify error
to basically just printout to stderr? we could just have it use log.error
like the other functions.
Pull Request Test Coverage Report for Build 58
💛 - Coveralls |
Remove magma specific logic. fault.logging.error() is now just a wrapper of python.logging.error().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Similar to magma logging module (magma/magma/logging.py).