Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp edit #116

Merged
merged 4 commits into from
Jun 10, 2019
Merged

Timestamp edit #116

merged 4 commits into from
Jun 10, 2019

Conversation

leonardt
Copy link
Owner

@leonardt leonardt commented Jun 6, 2019

Addresses issue where ncsim will not recompile a test bench if the new test bench file is generated within 1 second of the previous test bench file, see StanfordAHA/lassen#111.

This forces fault to, by default, check whether the test bench exists, if so, diff the modification timestamp on the new file with the old file. if the new file is less than or equal (handling the case when this happens multiple times in a row), fault sets the new file to be "newer" than the old file.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1051

  • 6 of 14 (42.86%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 75.983%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fault/system_verilog_target.py 6 14 42.86%
Totals Coverage Status
Change from base Build 1029: -0.3%
Covered Lines: 1392
Relevant Lines: 1832

💛 - Coveralls

Copy link
Collaborator

@Kuree Kuree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leonardt leonardt merged commit caf0097 into master Jun 10, 2019
@leonardt leonardt deleted the timestamp-edit branch June 10, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants