Update implementation for int_vector branch of bit_vector #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tracking leonardt/hwtypes#8 |
Pull Request Test Coverage Report for Build 117
💛 - Coveralls |
rsetaluri
reviewed
Aug 2, 2018
fault/python_simulator_target.py
Outdated
|
|
||
| def __check(self, sim_val, expected_val): | ||
| if expected_val is None: | ||
| # Expected None, skipping |
There was a problem hiding this comment.
should we print some warning in this case? why would expected_val be None?
There was a problem hiding this comment.
I believe we are using None to mean any value. This seems likely to cause problems in the future.
There was a problem hiding this comment.
Perhaps we could use some object called Any? Basically, we need a way of specifying in a testvector to not check an output value. The idea with None is if that "There is no expected value". An Any object could also work: it can be any value.
There was a problem hiding this comment.
Seems like a good idea. As long as it doesn’t confuse ppl with the generic type construct Any. Perhaps AnyValue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.