Switch over to using bit vectors #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 125
💛 - Coveralls |
leonardt
reviewed
Aug 15, 2018
| @@ -30,20 +30,23 @@ def generate_function_test_vectors(circuit, func, input_ranges=None, | |||
| for i, (name, port) in enumerate(circuit.interface.ports.items()): | |||
| if port.isoutput(): | |||
| if isinstance(port, BitType): | |||
| args.append([0, 1]) | |||
| args.append([BitVector(0), BitVector(1)]) | |||
There was a problem hiding this comment.
We may want to make a Bit type as opposed to BitVector since this is not a multibit value. We could use Python bools for Bits, but they have some funky behavior
>>> ~True
-2
which would motivate defining our own wrapper class with the operator semantics we expect
There was a problem hiding this comment.
I like the idea of a Bit type with the exact same semantics. python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the test vector generators used to return plain ints. Now it returns bit vectors to make everything consistent.