New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for flattening tuple types for verilator #39

Merged

leonardt merged 4 commits into master from add-tuple-support-verilator-target

Sep 19, 2018

Collaborator

rsetaluri commented Sep 18, 2018

No description provided.


          Add support for flattening tuple types for verilator

080fdbf

rsetaluri requested a review from leonardt

September 18, 2018 23:30

coveralls commented Sep 18, 2018 •

edited

Loading

Pull Request Test Coverage Report for Build 301

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.09%) to 81.377%

Files with Coverage Reduction	New Missed Lines	%
fault/verilator_utils.py	1	95.65%

Totals
Change from base Build 293:	0.09%
Covered Lines:	520
Relevant Lines:	639

💛 - Coveralls

leonardt requested changes

View reviewed changes

Owner

leonardt left a comment

LGTM, can we get a test? I think a simple one would just add a Tuple circuit to https://github.com/leonardt/fault/blob/master/tests/common.py and compile/test it in https://github.com/leonardt/fault/blob/master/tests/test_verilator_target.py


          Add tests for verilator tuples

Collaborator Author

rsetaluri commented Sep 18, 2018

Done


          Pep8 fix

leonardt approved these changes

View reviewed changes

Owner

leonardt left a comment

LGTM


          Pep8 fix

ed66457

leonardt merged commit 803451a into master

leonardt deleted the add-tuple-support-verilator-target branch

September 19, 2018 03:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment