Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verilator peek #53

Merged
merged 2 commits into from
Dec 18, 2018
Merged

Fix verilator peek #53

merged 2 commits into from
Dec 18, 2018

Conversation

rsetaluri
Copy link
Collaborator

Fixes a bug in how we generate code for Peeks in the verilator backend.

StanfordAHA/garnet#122 is blocked on this.

@rsetaluri rsetaluri mentioned this pull request Dec 18, 2018
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 444

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.288%
Totals Coverage Status
Change from base Build 439: 0.0%
Covered Lines: 613
Relevant Lines: 848
💛 - Coveralls

leonardt
leonardt approved these changes Dec 18, 2018
View reviewed changes
Copy link
Owner

@leonardt leonardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonardt leonardt merged commit 6c1822c into master Dec 18, 2018
@leonardt leonardt deleted the fix-verilator-peek branch December 18, 2018 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardt leonardt leonardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rsetaluri @coveralls @leonardt