added a substitute method to SMTBit and SMTBitVector #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdaly525
force-pushed
the
substitute
branch
from
d7b3720
to
63c5eb8
Compare
|
I do not think that this change affects the negative coverage. All new code paths are covered. |
|
Is there a reason this should be a method and not a function? I am reluctant to add methods to bitvector classes as it breaks their interoperability. |
|
It is a natural method on SMTBitVectors. What is the issue with adding methods to inherited classes from AbstractBitVector? I am not changing AbstractBitVector |
|
We have had problems in the past with people expecting that if it works with one version of bitvector then it works with all. Hence I would like to avoid creating cases where that is not the case but if you feel strongly that this should be a method we can pull this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.