Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for string port #14

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Add support for string port #14

merged 1 commit into from
Jul 10, 2019

Conversation

leonardt
Copy link
Owner

@leonardt leonardt commented Jul 9, 2019

Needed for the coreir verilog backend which represents the verilog ports of the primitive using a vector of strings

@leonardt leonardt requested a review from rdaly525 July 9, 2019 23:44
Copy link
Collaborator

@rdaly525 rdaly525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for compatibility purposes. But in the future this should not be needed as ideally this AST is the verilog mechanism for CoreIR.

@leonardt
Copy link
Owner Author

Yes, this would involve rewriting the definitions of the coreir verilog primitives to be compatible with the verilogAST, but for now this was easier to get something working

@leonardt leonardt merged commit 244b2c5 into master Jul 10, 2019
@leonardt leonardt deleted the string branch December 2, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants