-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline assigns #29
Merged
Merged
Inline assigns #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Forgot to do a code cleanup pass before submitting, so I'll do that, but feel free to point out any suggestions on refactoring) |
Also, this requires that assignments are in topologically sorted order (not necessary in Verilog). Fortunately (for now), the corier backend emits the statements in this order, but to support more general trees in the future we could simply sort the statements first. |
This reverts commit 60a98e7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial support for inlining assignment statements.
There's probably more cases to consider, but I think this should be a start for the coreir verilog backend (inlining primitive expressions/wires).
Requires the addition of copy constructors and cloning unique ptr logic for Expressions (eventually we'll want to extend this to support all node types).
Adds basic logic for inlining continuous wire assignments. When a wire is only read once, it will be replaced with it's driver. If it's read more than once, it will only be replaced if it it's driven by another wire (so it won't propagate/duplicate expressions, just names)
Perhaps a better name for this is wire propagation?