-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a parameterized verilog module test #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo newline nitpicks
CMakeLists.txt
Outdated
add_executable(parameterized_module tests/parameterized_module.cpp) | ||
target_link_libraries(parameterized_module gtest_main ${LIBRARY_NAME}) | ||
add_test(NAME parameterized_module_tests COMMAND parameterized_module) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) extra newline
include/verilogAST.hpp
Outdated
@@ -18,6 +18,7 @@ class Expression : public Node { | |||
|
|||
enum Radix { BINARY, OCTAL, HEX, DECIMAL }; | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) extra newline
depends on #7