Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a parameterized verilog module test #8

Merged
merged 6 commits into from
Jun 19, 2019
Merged

Conversation

rdaly525
Copy link
Collaborator

depends on #7

@rdaly525 rdaly525 requested a review from leonardt June 18, 2019 23:54
Copy link
Owner

@leonardt leonardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo newline nitpicks

CMakeLists.txt Outdated
add_executable(parameterized_module tests/parameterized_module.cpp)
target_link_libraries(parameterized_module gtest_main ${LIBRARY_NAME})
add_test(NAME parameterized_module_tests COMMAND parameterized_module)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) extra newline

@@ -18,6 +18,7 @@ class Expression : public Node {

enum Radix { BINARY, OCTAL, HEX, DECIMAL };


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) extra newline

@rdaly525 rdaly525 merged commit 622de1d into master Jun 19, 2019
@rdaly525 rdaly525 deleted the parameterized-test branch June 19, 2019 01:03
@rdaly525 rdaly525 mentioned this pull request Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants