-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker support #5
Conversation
Thanks for this! I don't have much experience with docker but it seems useful. Is the |
P.S. Also, do you have examples of pages which fail the boards rendering? Always useful to have a failing test case. |
This worked for me, thanks. Only surprising thing was that it defaulted to outputting in /tmp instead of ./dist/ by default. Might want to either change that default path or else have the default example include passing an env var like To take this further, it'd be great to see this merged and then have a Docker image pushed to Dockerhub. I think that would then enable a single command to run this without even having to have the locomotion git repo checked out locally at all. I'd love to run a single command (or docker-compose.yml file only) in my GitHub repo directory that builds and outputs right there so I can just git push & host the HTML in GitHub Pages. |
@NanoBjorn what do you think about that? As of now, I made a little script https://github.com/philfreo/sjc.vote/blob/main/update for a one liner to run which requires that this branch of loconotion is checked out in a sibling directory to my own static site. With the changes mentioned above I think this could be simplified. |
I thought that for local use |
While I disagree (since the output is the important artifact, not a 'temp' file), I suppose that's @leoncvlt's call –– and ultimately I'd be happy for this to get merged regardless of the default path, and pushed to dockerhub. I agree improving the README to mention the env var would definitely help. |
Hello!
Wanted to render one page regularly and to avoid chromedriver struggles on any OS, so wrote a
docker/Dockerfile
anddocker-compose.yml
. Also added small instruction to readme.P.S. Btw it seems that loconotion does not support Boards rendering. Tried mine and had very bad buggy page.