Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NerlnetApp] Critical bugs in distributed running #294

Merged
merged 16 commits into from
Mar 24, 2024
Merged

Conversation

leondavi
Copy link
Owner

@leondavi leondavi commented Mar 22, 2024

Fixes in this PR:

  • There was no a multipart implementation from cowboy to cowboy http communication - Fixed
  • Flask is very limited in terms of serving many connections at once. Therefore, batches can't be sent from cowboy in a manner of transaction per batch. I've implemented an ets that collects all of results data in main server and send it as a single chunk of data.
  • Sending json to devices was never tested on multiple devices and there were bugs there that I fixed
  • Due to flask issue that some of post messages get 200 ok but actually not handled I've added a
  • Add ack from apiserver back to main server to improve the redundancy of the ack mechanism in case of bad connection to apiserver
  • Fixed issue that caused sourceWaitingList to be empty and cut the flow of experiment. This is due to the fact that sources gets their source piece one by another. The fix is to send total count of sources to know how many are expected to take a part in experiment phase.

@leondavi leondavi changed the title [NERLPLANNER] Fix issue of ModelType bool when integer is 0 [NerlnetApp] Critical bugs in distributed running Mar 23, 2024
@leondavi leondavi merged commit 3d4006a into master Mar 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant