Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] status_value is required #27

Closed
aomarks opened this issue Jan 19, 2022 · 2 comments · Fixed by #28
Closed

[BUG] status_value is required #27

aomarks opened this issue Jan 19, 2022 · 2 comments · Fixed by #28
Assignees
@leonsteinhaeuser
Labels
bug Something isn't working

Comments

@aomarks
Copy link

aomarks commented Jan 19, 2022

The documentation states that status_value is not required, and that "If left unspecified, new items are added without an explicit status, and existing items are left alone.

However, when running the action without status_value set, I get the error Parameter 1: RESOURCE_NODE_VALUE is not set.

It looks like this line could be the culprit (it appears to be checking that the variable is not empty):

project-beta-automations/entrypoint.sh

Line 64 in 5d71b8d

if [ -z "$RESOURCE_NODE_VALUE" ]; then

@aomarks aomarks added the bug Something isn't working label Jan 19, 2022
aomarks added a commit to lit/lit that referenced this issue Jan 20, 2022
@aomarks
Use graphql API directly to automate adding issues to project
6441615 
The workflow I was trying from https://github.com/leonsteinhaeuser/project-beta-automations didn't work (filed leonsteinhaeuser/project-beta-automations#27).

But I realized we could use the graphql API directly to get more control here. This new action is based on the example at https://docs.github.com/en/issues/trying-out-the-new-projects-experience/automating-projects#example-workflow-authenticating-with-a-personal-access-token, just slightly modified and simplified.

I've tested this in my personal repo and it works, so hopefully it will work for us too.
@aomarks aomarks mentioned this issue Jan 20, 2022
Merged
aomarks added a commit to lit/lit that referenced this issue Jan 20, 2022
@aomarks
Use graphql API directly to automate adding issues to project (#2424)
ac7114b 
The workflow I was trying from https://github.com/leonsteinhaeuser/project-beta-automations didn't work (filed leonsteinhaeuser/project-beta-automations#27).

But I realized we could use the graphql API directly to get more control here. This new action is based on the example at https://docs.github.com/en/issues/trying-out-the-new-projects-experience/automating-projects#example-workflow-authenticating-with-a-personal-access-token, just slightly modified and simplified.

I've tested this in my personal repo and it works, so hopefully it will work for us too.
@leonsteinhaeuser
Copy link
Owner

Thank you very much for this catch. When I introduced the "custom_field" support, I added this check to verify that the user has provided data required to update custom fields. It seems that I forgot the precondition check for the operation_mode custom_field.

@leonsteinhaeuser leonsteinhaeuser linked a pull request Jan 24, 2022 that will close this issue
fix: status value not required #28
Merged
@leonsteinhaeuser leonsteinhaeuser self-assigned this Jan 24, 2022
@leonsteinhaeuser leonsteinhaeuser mentioned this issue Jan 27, 2022
Merged
@leonsteinhaeuser
Copy link
Owner

@aomarks I have fixed your described problem and created a new release: v1.1.1

If you notice any strange behavior, feel free to reopen this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leonsteinhaeuser leonsteinhaeuser

Labels
bug Something isn't working
Projects
ProjectV2 Automation
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: status value not required leonsteinhaeuser/project-beta-automations
2 participants
@aomarks @leonsteinhaeuser