Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deafultHTML for generateEmail method #108

Closed
niloysikdar opened this issue Sep 10, 2022 · 1 comment · Fixed by #109
Closed

Fix deafultHTML for generateEmail method #108

niloysikdar opened this issue Sep 10, 2022 · 1 comment · Fixed by #109
Assignees
@niloysikdar
Labels
GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 released

Comments

@niloysikdar
Copy link
Member

Description:

The current defaultHTML has few issues when comes to the compatibility with the different email clients. We need to optimize and fix the defaultEmail to add support for as many email clients as possible.

Solution:

We can follow this template to add compatibility for a batter range of email clients.
@niloysikdar niloysikdar added the GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 label Sep 10, 2022
niloysikdar added a commit that referenced this issue Sep 10, 2022
@niloysikdar
fix(defaulthtml): fix defaultHTML
d421f69 
Fix the default HTML which is used for the generateEmail function to convert the react layout and
generate the HTML out of it

Fixes #108

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar niloysikdar mentioned this issue Sep 10, 2022
Merged
agentmilindu pushed a commit that referenced this issue Sep 10, 2022
@niloysikdar
fix(defaulthtml): fix defaultHTML (#109)
d24426d 
Fix the default HTML which is used for the generateEmail function to convert the react layout and
generate the HTML out of it

Fixes #108

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
github-actions bot pushed a commit that referenced this issue Sep 10, 2022
@semantic-release-bot
chore(release): 1.15.1 [skip ci]
58a2a05 
## [1.15.1](v1.15.0...v1.15.1) (2022-09-10)

### Bug Fixes

* **defaulthtml:** fix defaultHTML ([#109](#109)) ([d24426d](d24426d)), closes [#108](#108)
@github-actions
Copy link

🎉 This PR is included in version 1.15.1 🎉

@niloysikdar niloysikdar self-assigned this Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloysikdar niloysikdar

Labels
GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 released
Projects
React Email
Status: Released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(defaulthtml): fix defaultHTML leopardslab/react-email
1 participant
@niloysikdar