Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggestion: run yarn dedupe #598

Closed
ewnu opened this issue May 10, 2022 · 3 comments · Fixed by #599 or #600
Closed

suggestion: run yarn dedupe #598

ewnu opened this issue May 10, 2022 · 3 comments · Fixed by #599 or #600
Labels
ci GitHub Actions workflow - Bundling / Building / Compiling / Integrating / Testing 🐞 Bugerino: Summin' ain't work'n jimmy
Projects
1337 - Template+
Milestone
Deduplicate depen...

Comments

@ewnu
Copy link

ewnu commented May 10, 2022

seems to me your template doesn't dedupe at all.
it saved almost 700 megs when I ran it.
leotm added a commit that referenced this issue May 10, 2022
@leotm
Dedupe yarn.lock post-Renovate pkg/artifact update
feea9eb 
- Run `yarn dedupe --strategy highest` after yarn lockfile updates with Renovate
  - More: https://yarnpkg.com/cli/dedupe#in-depth-explanation
- Fix: #598
@leotm leotm mentioned this issue May 10, 2022
Merged
@leotm leotm added 🐞 Bugerino: Summin' ain't work'n jimmy ci GitHub Actions workflow - Bundling / Building / Compiling / Integrating / Testing labels May 10, 2022
@leotm leotm added this to In progress in 1337 - Template+ May 10, 2022
leotm added a commit that referenced this issue May 10, 2022
@leotm
Dedupe yarn lockfile deps with overlapping ranges
7c9e7c8 
- Fix: #598
- Along with: #599
- More: https://yarnpkg.com/cli/dedupe#in-depth-explanation
@leotm leotm mentioned this issue May 10, 2022
Merged
1337 - Template+ automation moved this from In progress to Done May 10, 2022
@leotm
Copy link
Owner

leotm commented May 10, 2022

good spot @ewnu, deduplicating doesn't seem to be the case anymore with Zero Installs

Zero installs setups: dependencies are deduped and committed directly to the repository, making builds more reproducible and avoiding version conflicts.

https://semaphoreci.com/blog/javascript-monorepos-yarn-workspaces

@leotm
Copy link
Owner

leotm commented May 10, 2022

fixed in

@leotm
Copy link
Owner

leotm commented May 10, 2022 •
edited

and should be prevented in

after @renovate-bot runs again on this repo to rebase all open PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci GitHub Actions workflow - Bundling / Building / Compiling / Integrating / Testing 🐞 Bugerino: Summin' ain't work'n jimmy
Projects
1337 - Template+
  
Done
Milestone
Deduplicate dependencies with overlap...
2 participants
@leotm @ewnu