Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RN w Storybook v6a and upg to v6b #616

Closed
leotm opened this issue May 13, 2022 · 0 comments · Fixed by #764
Closed

Fix RN w Storybook v6a and upg to v6b #616

leotm opened this issue May 13, 2022 · 0 comments · Fixed by #764
Labels
hermes JS engine for RN (optimised: TTI, size, RAM) new arch Fabric / TurboModules / JSI changes p: Facebook Partner: Meta p: Storybook react native react-native-community.github.io/upgrade-helper storybook Storybook changes
Projects
1337 - Template+
Milestone
Storybook v6 beta

Comments

@leotm
Copy link
Owner

leotm commented May 13, 2022 •
edited

Context

Fix runtime error (crash)

Invariant Violation: ViewPropTypes has been removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'., js engine: hermes
hot-reload App -> StorybookUIRoot

Simulator Screen Shot - iPhone 13 - 2022-07-11 at 14 14 45

react-native-template-new-architecture/src/index.tsx

Line 22 in 59f358e

// TODO: Fix Storybook v6.0.1-alpha.7 crash and upgrade to v6.0.1-beta.6

storybook 6.3.1, 6.0.1-beta.6
https://github.com/storybookjs/react-native/blob/next-6.0/examples/native

storybook 6.3, addons 6.0.1-beta.5
https://github.com/dannyhw/react-native-storybook-starter

may need to downgrade current @next devdep addons from 6.5.x
@leotm leotm added this to the Storybook v6 beta milestone May 13, 2022
leotm added a commit that referenced this issue May 13, 2022
@leotm
TODO: Fix Storybook 6-alpha crash and upg to beta
a036e84 
- Remove StorybookUIRoot from entry condition causing crash
- Prefix _StorybookUIRoot so import only parsed
- Doc TODO

#616
@leotm leotm added this to In progress in 1337 - Template+ Jun 14, 2022
@leotm leotm added the p: Facebook Partner: Meta label Jul 11, 2022
@leotm leotm changed the title Storybook v6 beta Fix Storybook v6a and upg to v6b Jul 11, 2022
@leotm leotm added hermes JS engine for RN (optimised: TTI, size, RAM) new arch Fabric / TurboModules / JSI changes labels Jul 11, 2022
@leotm leotm changed the title Fix Storybook v6a and upg to v6b Fix RN w Storybook v6a and upg to v6b Jul 11, 2022
@leotm leotm added react native react-native-community.github.io/upgrade-helper storybook Storybook changes p: Storybook labels Jul 12, 2022
leotm added a commit that referenced this issue Jul 12, 2022
@leotm
Upgrade RN Storybook/addons from next(v6.0.1-alpha.7) to v6.0.1-beta.6
6b52057 
Fix: #616

Some left on `@next` if Yarn unable to find v6.0.1-beta.6

Note RN Storybook
- v5.3: /stories, w static analysis (remove or refactor)
- v6: .storybook, w minimal config w/o stories

Note Jest setup mocks
- @storybook/addon-ondevice-notes/register parsing issue
- @storybook/addon-actions ES forEach proto parsing issue

StorybookUIRoot
- static analysis passing
- Jest snapshot passing w StorybookUIRoot and mocks
@leotm leotm mentioned this issue Jul 12, 2022
Merged
1337 - Template+ automation moved this from In progress to Done Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hermes JS engine for RN (optimised: TTI, size, RAM) new arch Fabric / TurboModules / JSI changes p: Facebook Partner: Meta p: Storybook react native react-native-community.github.io/upgrade-helper storybook Storybook changes
Projects
1337 - Template+
  
Done
Milestone
Storybook v6 beta
1 participant
@leotm