Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Yarn 3.2.1 to 4.0.0-rc.9+ #672

Closed
wants to merge 12 commits into from
Closed

Upgrade Yarn 3.2.1 to 4.0.0-rc.9+ #672

wants to merge 12 commits into from

Conversation

leotm
Copy link
Owner

@leotm leotm commented Jun 13, 2022 •
edited
Loading

Only issue in Linux CI, macOS 13b locally is fine

Latest checked: rc.14

Ubuntu2204 (20220605.1)

yarn install
➤ YN0000: ┌ Resolution step
➤ YN0078: │ Invalid resolution node-forge@npm:^0.10.0 → npm:1.2.1 (yarn why: ... RN Flipper)
➤ YN0000: └ Completed
➤ YN0000: Failed with errors in 0s 137ms
  • revert yarn.lock (v4 -> v3)
  • revert (old v3) resolution commit
  • yarn install (regen v4 lockfile)
yarn --check-resolutions
➤ YN0000: ┌ Resolution step
➤ YN0078: │ Invalid resolution prismjs@npm:~1.17.0 → npm:1.26.0 (yarn why: ... @storybook)
➤ YN0000: └ Completed
➤ YN0000: Failed with errors in 0s 137ms
  • repeat

Similar on macOS Monterey 12.5 Beta

  • doesn't block yarn install
  • detected via yarn --check-resolutions

Next step

Follow-up

Still need to undo resolutions

Close: #671

@leotm leotm added this to the Yarn 4 milestone Jun 13, 2022
@leotm leotm marked this pull request as ready for review June 13, 2022 15:12
@leotm leotm marked this pull request as draft June 13, 2022 15:22
@leotm
Copy link
Owner Author

leotm commented Jun 14, 2022 •
edited
Loading

Check

@leotm leotm added ci GitHub Actions workflow - Bundling / Building / Compiling / Integrating / Testing 🐧 Linux: Ubuntu 22.04 LTS for Android CI labels Jun 14, 2022
@leotm
Copy link
Owner Author

leotm commented Jun 14, 2022 •
edited
Loading

Yarn 4.0.0-rc.9 --check-resolutions (can't check in v3) recognising all prev/old v3 (manual) set resolutions Invalid

yarn set version canary
yarn install
yarn --check-resolutions
➤ YN0000: ┌ Resolution step
➤ YN0078: │ Invalid resolution node-forge@npm:^0.10.0 → npm:1.2.1 (yarn why: ... RN Flipper)
➤ YN0000: └ Completed
➤ YN0000: Failed with errors in 0s 137ms

revert yarn.lock (v4 -> v3)

revert (old v3) resolution commit

yarn install (regen v4 lockfile)

yarn --check-resolutions
➤ YN0000: ┌ Resolution step
➤ YN0078: │ Invalid resolution prismjs@npm:~1.17.0 → npm:1.26.0 (yarn why: ... @storybook)
➤ YN0000: └ Completed
➤ YN0000: Failed with errors in 0s 137ms

yarn install blocker on Ubuntu, not on macOS but still detected

@leotm leotm mentioned this pull request Jun 14, 2022
Merged
3 tasks
@leotm leotm added this to In progress in 1337 - Template+ Jun 28, 2022
@leotm leotm removed this from In progress in 1337 - Template+ Jun 28, 2022
@leotm leotm changed the title Upgrade Yarn 3.2.1 to 4.0.0-rc.9 Upgrade Yarn 3.2.1 to 4.0.0-rc.10 Jun 30, 2022
@leotm
Copy link
Owner Author

leotm commented Jul 5, 2022 •
edited
Loading

yarn patch --revert-all --dev-deps needed 😅 or yarn reset resolutions -D or lockfile codemod

edit: ok only few

shouldn't be necessary to upg Yarn v3 -> v4 🤔

temp: revert commits in order

solution: difficult w/o commit hist since lockfile snapshot overwritten 5x

hack: delete yarn lockfile to remove Yarn v3 resolutions, then re-create with Yarn v4? but resolutions lost on devDeps

@leotm leotm changed the title Upgrade Yarn 3.2.1 to 4.0.0-rc.10 Upgrade Yarn 3.2.1 to 4.0.0-rc.10+ Jul 5, 2022
@leotm leotm changed the title Upgrade Yarn 3.2.1 to 4.0.0-rc.10+ Upgrade Yarn 3.2.1 to 4.0.0-rc.9+ Jul 5, 2022
@leotm leotm changed the title Upgrade Yarn 3.2.1 to 4.0.0-rc.9+ Upgrade Yarn 3.2.1 to 4.0.0-rc.9+ (11 atm) Jul 5, 2022
@leotm leotm mentioned this pull request Jul 21, 2022
Closed
@leotm leotm changed the title Upgrade Yarn 3.2.1 to 4.0.0-rc.9+ (11 atm) Upgrade Yarn 3.2.1 to 4.0.0-rc.9+ Aug 7, 2022
@leotm leotm added the 🚫 Blocked label Aug 8, 2022
@leotm leotm mentioned this pull request Aug 16, 2022
Closed
@leotm
Copy link
Owner Author

leotm commented Aug 16, 2022

follow-up attempt here: #846

@leotm leotm mentioned this pull request Nov 11, 2022
Closed
leotm added a commit that referenced this pull request Nov 16, 2022
@leotm
Upgrade Yarn from v3.3.0 to v4.0.0-rc.28
a11477d 
Close: #1181

Close: #672
@leotm leotm mentioned this pull request Nov 16, 2022
Merged
@leotm leotm added p: Yarn Yarn and removed 🚫 Blocked labels Nov 16, 2022
@leotm
Copy link
Owner Author

leotm commented Nov 16, 2022

Raised in

Followed up in

@leotm leotm closed this in 4b362eb Dec 8, 2022
@leotm leotm closed this in #1205 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci GitHub Actions workflow - Bundling / Building / Compiling / Integrating / Testing p: Yarn Yarn 🐧 Linux: Ubuntu 22.04 LTS for Android CI
Projects
None yet
Milestone
Yarn 4
Development

Successfully merging this pull request may close these issues.

Upgrade Yarn 3.2.1 to 4.0.0-rc.9
1 participant
@leotm