Bug Fix: prism code giving strange results when below#12
Merged
Conversation
arctan2 not returns positive results for negative angles sometimes. The fix corrects the angle depending on sign of input.
Need to make more for the other fields
Safe versions of atan2 and log that can handle the limits used in the prism codes (log(0) and correct the sign of tangents).
Owner
Author
|
gxy, gxz and gyz have a singularity in certain plains around the prism. They fall on the vertices of the prism. |
Weird behavior and it seems to happen with all cross components
leouieda
changed the title
The cross components all fail on the edges of the prism. Will add an if for that case and add a dummy value to account for it.
The cross-components of the prism gravity gradient were failing on the corners of the prism in one of the faces. Put a check if on that face, then move the point some percentage of the prism dimensions.
Owner
Author
|
There was also a problem in the cross components with the log functions. If the the point is aligned with the corner, a log(0) was being evaluated as depending on which size of the prism you are in. |
leouieda
added a commit
that referenced
this pull request
Jul 16, 2014
Bug Fix: prism code giving strange results when below
leouieda
added a commit
that referenced
this pull request
Jul 16, 2014
Bug Fix: prism code giving strange results when below
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was actually in the atan2 function:
The fix was to wrap atan2 and fix the result to fall where I want it to.