New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: prism code giving strange results when below #12

Merged
merged 11 commits into from Jul 16, 2014

Conversation

Projects
None yet
1 participant
@leouieda
Copy link
Owner

leouieda commented May 26, 2014

The problem was actually in the atan2 function:

  • sometimes returns positive values for negative angles and vice-versa
  • sometimes returns 2*pi for zero angle

The fix was to wrap atan2 and fix the result to fall where I want it to.

  • Changelog entry
  • All tests pass
  • Can be merged
  • Documentation

leouieda added some commits May 26, 2014

Started bug fix for arctan2 behaviour in prism
arctan2 not returns positive results for negative angles sometimes. The
fix corrects the angle depending on sign of input.
Added test for prism_gx around the prism
Need to make more for the other fields
Created safe_log and safe_atan2 funcs for prism
Safe versions of atan2 and log that can handle the limits used in the
prism codes (log(0) and correct the sign of tangents).
@leouieda

This comment has been minimized.

Copy link
Owner

leouieda commented May 28, 2014

gxy, gxz and gyz have a singularity in certain plains around the prism. They fall on the vertices of the prism.

prism gxy fails below the prism at the corners
Weird behavior and it seems to happen with all cross components

@leouieda leouieda changed the title Fix: prism code giving strange results when below Bug Fix: prism code giving strange results when below May 30, 2014

leouieda added some commits Jul 15, 2014

Testing all components around the prism
The cross components all fail on the edges of the prism. Will add an if
for that case and add a dummy value to account for it.
Move obs point if on corner of prism cross comps
The cross-components of the prism gravity gradient were failing on the
corners of the prism in one of the faces. Put a check if on that face,
then move the point some percentage of the prism dimensions.
@leouieda

This comment has been minimized.

Copy link
Owner

leouieda commented Jul 16, 2014

There was also a problem in the cross components with the log functions. If the the point is aligned with the corner, a log(0) was being evaluated as depending on which size of the prism you are in.

leouieda added a commit that referenced this pull request Jul 16, 2014

Merge pull request #12 from leouieda/bug-prism-arctan2
Bug Fix: prism code giving strange results when below

@leouieda leouieda merged commit 6648627 into master Jul 16, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@leouieda leouieda deleted the bug-prism-arctan2 branch Jul 16, 2014

leouieda added a commit that referenced this pull request Jul 16, 2014

Merge pull request #12 from leouieda/bug-prism-arctan2
Bug Fix: prism code giving strange results when below
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment