Merge pull request #132 from leouofa/pillar-topic-population

Added Pillar Topic Population

app/jobs/pillar_job.rb

@@ -17,9 +17,12 @@ def perform(*_args)
       # [x] Add Pillar Columns for Each Pillar
       Pillars::IterateThroughPillarsJob.perform_now
 
-      # [ ] Create Topics for each Pillar Column
+      # [x] Create Topics for each Pillar Column
       Pillars::IterateThroughPillarColumnsJob.perform_now
 
+      # [x] Creates Pillar Topics from Pillar Columns
+      Pillars::CreatePillarTopicsJob.perform_now
+
       # [x] Adds Articles for each Pillar Columns
       # Articles::IterateThroughPillarColumnsJob.perform_now
     ensure

app/jobs/pillars/create_pillar_topics_job.rb

@@ -0,0 +1,22 @@
+class Pillars::CreatePillarTopicsJob < ApplicationJob
+  queue_as :default
+
+  def perform(*args)
+    PillarColumn.with_topics.unprocessed.each do |pillar_column|
+      process_pillar_column(pillar_column:)
+    end
+  end
+
+  private
+
+  def process_pillar_column(pillar_column:)
+    pillar_column.topics.each do |pillar_topic|
+      create_pillar_topic(pillar_column: ,pillar_topic:)
+    end
+    pillar_column.update(processed: true)
+  end
+
+  def create_pillar_topic(pillar_column:, pillar_topic:)
+    PillarTopic.create!(pillar_column: pillar_column, title: pillar_topic["title"], summary: pillar_topic["summary"])
+  end
+end

app/models/pillar_column.rb

@@ -9,7 +9,14 @@
 #  created_at  :datetime         not null
 #  updated_at  :datetime         not null
 #  topics      :text
-#
+#  processed   :boolean          default(FALSE)
+
+################ LOGIC #################
+# - The `processed` value is set to true once the pillar column has been parsed and the feed items have been created.
+#   * This ensures that the column only gets processed once.
+#   * The value is set by the create_pillar_topics_job.rb job.
+########################################
+
 class PillarColumn < ApplicationRecord
   belongs_to :pillar
   has_many :articles
@@ -21,4 +28,5 @@ class PillarColumn < ApplicationRecord
 
   scope :without_topics, -> { where(topics: nil) }
   scope :with_topics, -> { where.not(topics: nil) }
+  scope :unprocessed, -> { where(processed: false) }
 end

db/migrate/20240629161427_add_processed_to_pillar_column.rb

@@ -0,0 +1,5 @@
+class AddProcessedToPillarColumn < ActiveRecord::Migration[7.0]
+  def change
+    add_column :pillar_columns, :processed, :boolean, default: false
+  end
+end

spec/factories/pillar_columns.rb

@@ -9,6 +9,7 @@
 #  created_at  :datetime         not null
 #  updated_at  :datetime         not null
 #  topics      :text
+#  processed   :boolean          default(FALSE)
 #
 FactoryBot.define do
   factory :pillar_column do

spec/jobs/pillars/create_pillar_topics_job_spec.rb

@@ -0,0 +1,24 @@
+require 'rails_helper'
+
+RSpec.describe Pillars::CreatePillarTopicsJob, type: :job do
+  let!(:pillar_column_with_topics) { create(:pillar_column, topics: [{ "title" => "Topic 1", "summary" => "Summary 1" }, { "title" => "Topic 2", "summary" => "Summary 2" }]) }
+  let!(:pillar_column_without_topics) { create(:pillar_column, topics: nil) }
+  let!(:processed_pillar_column) { create(:pillar_column, topics: [{ "title" => "Topic 3", "summary" => "Summary 3" }], processed: true) }
+
+  describe '#perform' do
+    it 'processes unprocessed pillar columns with topics' do
+      expect { described_class.perform_now }.to change { PillarTopic.count }.by(2)
+
+      pillar_column_with_topics.reload
+      expect(pillar_column_with_topics.processed).to be_truthy
+    end
+
+    it 'does not process already processed pillar columns' do
+      expect { described_class.perform_now }.not_to(change { processed_pillar_column.pillar_topics.count })
+    end
+
+    it 'does not process pillar columns without topics' do
+      expect { described_class.perform_now }.not_to(change { pillar_column_without_topics.pillar_topics.count })
+    end
+  end
+end

spec/models/pillar_column_spec.rb

@@ -9,8 +9,8 @@
 #  created_at  :datetime         not null
 #  updated_at  :datetime         not null
 #  topics      :text
+#  processed   :boolean          default(FALSE)
 #
-# spec/models/pillar_column_spec.rb
 
 require 'rails_helper'