Made type error more clear in ACF loading #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
@NullSoldier can you change TypeError message in a couple other places too, so that they behave the same across the library? |
|
Will do that shortly. |
|
Modified and squashed. I could have created a TypeMismatch exception that did this type of message but I think most people expect a TypeError specifically and you'd have to bump the major version. I think this is simple enough. |
|
Looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was checking my logs and a user ran into this exception but I have no idea why as I'm using Python3 and pass something should be clearly a string.
Since this already throws an exception I feel like it could be slightly more helpful to the user.