Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common.j: Describe SetPlayerAlliance (enemy test) #123

Merged
merged 3 commits into from Nov 20, 2023
Merged

Conversation

Luashine
Copy link
Collaborator

I'll soon finish writing this "tutorial" on Hive: "How to control enemy player's units (for play testing)"

@Luashine
Copy link
Collaborator Author

Huh looks like I made a branch on this repo, rather than my own... Oh GitHub Web :)

@lep
Copy link
Owner

lep commented Nov 20, 2023

Looks good to me. Except you probably wanted the example not be part of the value parameter. That's how the parser sees it currently.

@Luashine
Copy link
Collaborator Author

100%! Haha :) Feel free to fix those mistakes yourself if you want.

@lep
Copy link
Owner

lep commented Nov 20, 2023

100%! Haha :) Feel free to fix those mistakes yourself if you want.

Alright, will keep that in mind for the future. I just feel a bit uneasy about commiting to other peoples PRs.

@lep lep merged commit dd193cb into master Nov 20, 2023
@Luashine
Copy link
Collaborator Author

I just feel a bit uneasy about commiting to other peoples PRs.

I understand but sometimes it's not worth the back and forth commenting ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants