Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin exit when transport is SMTP #58

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pawelangelow
Copy link

Problem: The plugin does not exit correctly when the transport is SMTP.

Why:
Triggering the fastify.nodemailer.close(done) is expected to
start disposing of resources procedure. However the mailer implementation
proxies the execution to the underlying SMTP transport.
In order to exit properly (after the plugin successfully closed),
the callback has to be called on the plugin event close.

@giovanni-bertoncelli
Copy link

Thank you, I've also opened an issue #107 but probably @lependu is not maintaining this anymore. Using this package should be avoided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants